iCloud Photo Library

This is a helpful article on whether or not to keep all your photos on your Mac or in the cloud. After reading it, I have chosen to keep all my photos on my Mac, but YMMV. Give it a read. It has some iCloud photo troubleshooting tips as well.

Doug